Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline devcontainer #19

Merged
merged 1 commit into from
May 12, 2024
Merged

Streamline devcontainer #19

merged 1 commit into from
May 12, 2024

Conversation

MusicalNinjaDad
Copy link
Owner

  • remove pyo3-core related stuff from devcontainer
  • align to MusicalNinjas/devcontainers-pyo3

Not directly pulling image from ghcr.io yet:

  1. would likely stop rust working on darwin, arm etc.
  2. want to keep the username: fizzbuzz (for now)

align to MusicalNinjas/devcontainers-pyo3
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @MusicalNinjaDad - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 2 issues found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

.devcontainer/devcontainer.json Show resolved Hide resolved
.devcontainer/check-rust.sh Show resolved Hide resolved
@MusicalNinjaDad MusicalNinjaDad merged commit 28b8d8f into main May 12, 2024
8 checks passed
@MusicalNinjaDad MusicalNinjaDad deleted the devcontainer branch May 12, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant