Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up wheel & devcontainer builds #28

Merged
merged 4 commits into from
May 16, 2024
Merged

Speed up wheel & devcontainer builds #28

merged 4 commits into from
May 16, 2024

Conversation

MusicalNinjaDad
Copy link
Owner

  • Use prebuilt pypa + rust + just images for building wheels
  • Build wheels for different linux architectures parallel in matrix
  • Use prebuilt image for devcontainer

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @MusicalNinjaDad - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

.github/workflows/deploy-python.yml Show resolved Hide resolved
@MusicalNinjaDad MusicalNinjaDad merged commit b90f62c into main May 16, 2024
14 checks passed
@MusicalNinjaDad MusicalNinjaDad deleted the build_speed branch May 16, 2024 05:54
MusicalNinjaDad added a commit that referenced this pull request May 16, 2024
- correct image names
- don't reinstall rust & just
MusicalNinjaDad added a commit that referenced this pull request May 16, 2024
MusicalNinjaDad added a commit that referenced this pull request May 16, 2024
fixed matrix naming and inclusion/exclusions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant