MultiFizzBuzz Ranges #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maybe has too many bounds: need to check whether all of ?Sized, Send, Send are needed
Tests fail
This reverts commit 42c3ea8.
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. 📢 Thoughts on this report? Let us know! |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @MusicalNinjaDad - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 5 issues found
- 🟢 Security: all looks good
- 🟡 Testing: 1 issue found
- 🟢 Complexity: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
MusicalNinjaDad
added a commit
that referenced
this pull request
Jun 2, 2024
Enable `MultiFizzBuzz` on `Range<i32>`, `RangeInclusive<i16>` and anything else which rayon can convert to an `IndexedParallelIterator`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable
MultiFizzBuzzonRange<i32>,RangeInclusive<i16>and anything else which rayon can convert to anIndexedParallelIterator