-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handle no connection #1078
base: master
Are you sure you want to change the base?
handle no connection #1078
Conversation
Deploying mutiny-web with Cloudflare Pages
|
src/router.tsx
Outdated
<Match when={state.network_status?.connectionType === "none"}> | ||
<NoConnection /> | ||
</Match> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should probably be before setup_error
. having no internet would likely be the cause of a setup error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One of the first things that gets returned from the setup phase is the LNURL call not working
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if you guys are agreeing or disagreeing here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreeing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay rebased and fixed
I don't like this. It's very jarring. It's one thing if it's during the setup, but if there's a little disconnection while on the home screen, the whole screen converts and flashes back when the connection resumes. This is not a good experience for a blip in connection issues. You can do a little disconnection icon at the top or something. |
if they go offline and the device can detect it we'll show them they're offline
https://capacitorjs.com/docs/apis/network