Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added features to be able to provided the selected image on tab item #1984

Merged
merged 2 commits into from Jun 22, 2017
Merged

added features to be able to provided the selected image on tab item #1984

merged 2 commits into from Jun 22, 2017

Conversation

ghost
Copy link

@ghost ghost commented Jun 22, 2017

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

feature

⤵️ What is the current behavior?

you can set a tab bar item's image, but not the selected image

🆕 What is the new behavior (if this is a feature change)?

you can provide the selected image icon

💥 Does this PR introduce a breaking change?

I don't think so because the string for selected image can be null and if it's null then it's not set on the tab bar item

🐛 Recommendations for testing

I updated the code in the play ground for testing

📝 Links to relevant issues/docs

I mentioned this in slack to the team

🤔 Checklist before submitting

  • All projects build
  • Follows style guide lines (code style guide)
  • Relevant documentation was updated (docs style guide)
  • Nuspec files were updated (when applicable)
  • Rebased onto current develop

@mention-bot
Copy link

@biozal, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nmilcoff, @Stephanvs and @tomgilder to be potential reviewers.

Copy link
Contributor

@nmilcoff nmilcoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only thing to notice: It is a breaking change. All apps that have overriden MvxTabBarViewController.ShowTabView and MvxTabBarViewController.SetTitleAndTabBarItem will break

@ghost
Copy link
Author

ghost commented Jun 22, 2017

@nmilcoff would the recommendation be to leave current methods in place and just have them call new methods with the new signature? Then this wouldn't break as the old method signatures would still be there and they would simply call the new ones.

@Cheesebaron Cheesebaron merged commit d4d1d80 into MvvmCross:develop Jun 22, 2017
@Cheesebaron Cheesebaron added this to the 5.0.4 milestone Jun 22, 2017
@Cheesebaron Cheesebaron added the p/ios iOS platform label Jun 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p/ios iOS platform
Development

Successfully merging this pull request may close these issues.

4 participants