Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test project.uwp #2007

Merged
merged 1 commit into from
Jul 1, 2017
Merged

Test project.uwp #2007

merged 1 commit into from
Jul 1, 2017

Conversation

flyingxu
Copy link

@flyingxu flyingxu commented Jun 30, 2017 •
edited by martijn00
Loading

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Bug fix

⤵️ What is the current behavior?

Example001CSharp/Example.UWP/Example.UWP.csproj and Example001XAML/Example.UWP/Example.UWP.csproj can't compile.

🆕 What is the new behavior (if this is a feature change)?

Both Example001CSharp/Example.UWP/Example.UWP.csproj and Example001XAML/Example.UWP/Example.UWP.csproj can compile without errors.

💥 Does this PR introduce a breaking change?

No

🐛 Recommendations for testing

Compile Example001CSharp/Example.UWP/Example.UWP.csproj and Example001XAML/Example.UWP/Example.UWP.csproj and see if there are errors.

📝 Links to relevant issues/docs

🤔 Checklist before submitting

  • All projects build
  • Follows style guide lines (code style guide)
  • Relevant documentation was updated (docs style guide)
  • Nuspec files were updated (when applicable)
  • Rebased onto current develop

@flyingxu flyingxu mentioned this pull request Jun 30, 2017
Merged
@Cheesebaron
Copy link
Member

This is not rebased on develop.

@flyingxu
Copy link
Author

flyingxu commented Jul 1, 2017 •
edited
Loading

How about now? I'm not a git expert, but now I have executed the rebase command. Could you review?

@martijn00
Copy link
Contributor

I've done the rebase. Thanks!

@martijn00 martijn00 merged commit 130de58 into MvvmCross:develop Jul 1, 2017
@flyingxu flyingxu deleted the TestProject.UWP branch July 2, 2017 00:58
@martijn00 martijn00 added this to the 5.0.6 milestone Jul 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martijn00 martijn00 martijn00 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
5.0.6
Development

Successfully merging this pull request may close these issues.
4 participants
@flyingxu @Cheesebaron @martijn00 @felixfxu