Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Margin target binding for Android #2780

Merged
merged 1 commit into from
Apr 9, 2018
Merged

Added Margin target binding for Android #2780

merged 1 commit into from
Apr 9, 2018

Conversation

Cheesebaron
Copy link
Member

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Feature

⤵️ What is the current behavior?

No way to bind Margins on Android Layouts

🆕 What is the new behavior (if this is a feature change)?

You can bind:

  • Margin (binds all margins to same value)
  • MarginLeft
  • MarginRight
  • MarginTop
  • MarginBottom
  • MarginStart
  • MarginEnd

💥 Does this PR introduce a breaking change?

Nope

🐛 Recommendations for testing

Try binding a margin

📝 Links to relevant issues/docs

🤔 Checklist before submitting

@Cheesebaron Cheesebaron added t/feature Feature request type p/android Android platform labels Apr 9, 2018
@martijn00 martijn00 added this to the 6.0.0 milestone Apr 9, 2018
@martijn00 martijn00 merged commit 6d7dbc6 into develop Apr 9, 2018
@Cheesebaron Cheesebaron deleted the feature/margin-target-binding branch April 9, 2018 11:47
@martijn00 martijn00 mentioned this pull request Apr 16, 2018
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martijn00 martijn00 martijn00 approved these changes

Assignees
No one assigned
Labels
p/android Android platform t/feature Feature request type
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Cheesebaron @martijn00