Android: Add support for ViewPagers inside Fragments #3001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmilcoff
added
t/bug
martijn00
approved these changes
Jul 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Bug fix / Feature which wasn't supported until now
When the app has a ViewPager inside a Fragment, and you try to display a tab inside of it using the NavigationService, the app will do weird things. Probably just crash.
Also when navigating forwards to nested fragments, those fragments are not stored in the correct FragmentManager, therefore they are not properly disposed afterwards.
🆕 What is the new behavior (if this is a feature change)?
Above is supported. Also The issue #2550 is addressed by this PR.
💥 Does this PR introduce a breaking change?
Nope
🐛 Recommendations for testing
Run Playground.Droid -> Navigate to Master/Details screen -> Tap on "Show tabs" button. Check everything works
📝 Links to relevant issues/docs
Fixes #2550.
This is also somehow related to #2440
🤔 Checklist before submitting