Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generating keystore in dev silently fails #1464

Closed
wbobeirne opened this issue Apr 6, 2018 · 1 comment
Closed

Generating keystore in dev silently fails #1464

wbobeirne opened this issue Apr 6, 2018 · 1 comment
Labels
type: issue Items that document a problem or bug with an existing feature.

Comments

@wbobeirne
Copy link
Contributor

wbobeirne commented Apr 6, 2018 •
edited
Loading

Description of the Issue

Trying to generate a keystore file in Electron causes a failure in the web worker:

Uncaught ReferenceError: window is not defined

I think this may be as simple as finding and changing wherever window is to self.

Steps to Reproduce

  1. Go to "Create New Wallet"
  2. Select keystore
  3. Enter password(s)
  4. Click generate
  5. Loads forever, error in console

Description of Your Machine

OSX 10.13.2
@wbobeirne wbobeirne added type: issue Items that document a problem or bug with an existing feature. S labels Apr 6, 2018
@wbobeirne
Copy link
Contributor Author

Turns out this is a dev-only HMR issue introduced in Webpack 4. Details are here: webpack/webpack#6642

@wbobeirne wbobeirne changed the title Generating keystore on Electron silently fails Generating keystore in dev silently fails Apr 6, 2018
@wbobeirne wbobeirne mentioned this issue Apr 6, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: issue Items that document a problem or bug with an existing feature.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wbobeirne