Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix keystore worker in dev #1465

Merged
merged 2 commits into from
Apr 6, 2018
Merged

Fix keystore worker in dev #1465

merged 2 commits into from
Apr 6, 2018

Conversation

wbobeirne
Copy link
Contributor

Closes #1464

Description

As of Webpack 4, workers unfortunately get some HMR code injected with them. These refer to the global window object, which doesn't exist in the worker context. So in dev, the global object will be changed to self which works in all newer JS environments.

Steps to Test

  1. Generate a keystore file in dev

@wbobeirne wbobeirne added the status: ready for review Open PR's that are ready for technical review. Replaced with "changes needed" or "ready to merge". label Apr 6, 2018
@coveralls
Copy link

Coverage Status

Coverage remained the same at 33.514% when pulling 92e716d on fix-dev-keystore-worker into 8fb0e03 on develop.

@wbobeirne wbobeirne requested a review from dternyak April 6, 2018 18:26
dternyak
dternyak approved these changes Apr 6, 2018
View reviewed changes
Copy link
Contributor

@dternyak dternyak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, confirmed working on macOS 10.13.3

@dternyak dternyak merged commit fde8867 into develop Apr 6, 2018
@dternyak dternyak deleted the fix-dev-keystore-worker branch April 6, 2018 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dternyak dternyak dternyak approved these changes

Assignees
No one assigned
Labels
status: ready for review Open PR's that are ready for technical review. Replaced with "changes needed" or "ready to merge".
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wbobeirne @coveralls @dternyak