Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix keystore worker in dev #1465

Merged
merged 2 commits into from
Apr 6, 2018
Merged

Fix keystore worker in dev #1465

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92e716d
Fix workers on dev from HMR idiocy.
wbobeirne Apr 6, 2018
8e3ccf9
Merge branch 'develop' into fix-dev-keystore-worker
dternyak Apr 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion webpack_config/makeConfig.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,9 @@ module.exports = function(opts = {}) {
path: path.resolve(config.path.output, options.outputDir),
filename: options.isProduction ? `[name].${commitHash}.js` : '[name].js',
publicPath: isDownloadable && options.isProduction ? './' : '/',
crossOriginLoading: 'anonymous'
crossOriginLoading: 'anonymous',
// Fix workers & HMR https://github.com/webpack/webpack/issues/6642
globalObject: options.isProduction ? undefined : 'self'
};

// The final bundle
Expand Down