Enable Ledger & Trezor on Desktop

[dternyak]

A large portion of the space on the default view of the MyCrypto Desktop applications goes to showing disabled wallet formats.

We can implement node-hid to get Ledger & Trezor working on Desktop, but web3 remains unsolved for the time being.

• Implement node-hid to enable ledger on desktop
• Implement trezor.js to enable Trezor on desktop

[jspence425]

Highlighting "Web3" on the Desktop app displays "This wallet is not supported in the MyCrypto app"
Highlighting "Ledger" on the Desktop app displays " This wallet is only supported at MyCrypto.com"

I understand there's a difference between the two but the messaging either needs to be the same for both (a large majority of our users do not care for the specific reason why they can't access in these manners, they'll just care that it can or cannot be used) or different for both but explained in detail for why you cannot access using these routes.

I would recommend saying "This wallet type is not supported on the MyCrypto app" as a catch-all.

[wbobeirne]

I think the goal by the time we launch this is to have these two sorted out. #921 should allow for Ledger on the app, and we're also eyeing https://github.com/MetaMask/mascara which could replace the Web3 option.

[dternyak]

Mascara is really early, so unfortunately it's not a good option for the foreseeable future. We can look into #921, but I don't see that viable in the next month, but perhaps a separate ledger implementation is.

…

On Wed, Apr 18, 2018 at 9:41 PM wbobeirne ***@***.***> wrote: I think the goal by the time we launch this is to have these two sorted out. #921 <#921> should allow for Ledger on the app, and we're also eyeing https://github.com/MetaMask/mascara which could replace the Web3 option. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1621 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHf02ZawagTsoT-f54vCJA8hlkWSTJ6Tks5tp_lAgaJpZM4TbByG> .

[wbobeirne]

I think I'd sooner whip up a temporary Ledger implementation that's not #921, than ship without supporting it. We should probably get that on the roadmap.

[dternyak]

@wbobeirne Yeah, absolutely. I think the node-hid approach might be the way to go for desktop apps, so we'll just have a separate implementation for desktop.

[wbobeirne]

Added Trezor to this since it has the same problem / solution, and tagging in Henry since he's working on the communication layer between Electron and the web app.