Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Trezor firmware breaks compatibility with MyCryptoWallet #2439

Closed
andreweximchain opened this issue Mar 18, 2019 · 3 comments
Closed
Labels
cat: hardware wallets Issues or features related to unlocking or sending with a hardware wallet. type: issue Items that document a problem or bug with an existing feature.

Comments

@andreweximchain
Copy link
Contributor

Updated Trezor firmware breaks compatibility with MyCryptoWallet

Hello, I have tried sending a transaction recently with the latest firmware update on trezor, but for whatever reason I'm getting a safety check failed red notification error when running in the yarn electron:dev mode. I also tested this issue with a fully built version of MyCrypto application, and to no avail. I also tested this against an older trezor with older firmware, and it seems to be fine there. For whatever reason, it seems that the ethereum signing check on the trezor fails.

https://github.com/trezor/trezor-mcu/blob/master/firmware/ethereum.c

If you want to check out the link above and go through it with a simple ctrl-f of "safety check failed" will show you where in the code the error is coming from.

Steps to Reproduce

  1. Update trezor one to firmware version 1.8.0
  2. Try to send a transaction
  3. Fail sending transaction due to safety check notification error.

Description of Your Machine

Running a 13 inch 2017 Macbook Pro with MacOS Mojave Version 10.14.3 (18D109)

Console Logs / Screenshots

image

I modified the trezor.js node_modules to print out the request and responses going to the trezor, and here are the console logs

image

@tayvano tayvano added type: issue Items that document a problem or bug with an existing feature. cat: hardware wallets Issues or features related to unlocking or sending with a hardware wallet. labels Mar 18, 2019
@tayvano
Copy link
Contributor

tayvano commented Mar 18, 2019

So basically, trezor.js is now deprecated but the new trezor connect isnt compatible with Electron.

Add'l info on Trezor's end here: trezor/connect#245

For now, advice for users is "use the website with your Trezor" until we figure out what needs to be done to resolve this

@andreweximchain
Copy link
Contributor Author

andreweximchain commented Mar 19, 2019

@tayvano found a workaround based on the @rodrigopavezi's suggestion in trezor/connect#245

However, I am unsure if it works with older firmware versions.
Here is the change:
andreweximchain@3f7aa8d

@blurpesec
Copy link
Collaborator

blurpesec commented Mar 20, 2019

@andreweximchain That's odd because i tested the same thing yesterday after @rodrigopavezi 's post and it didnt work. But then i tested again just now and it did... >.> odd. Thanks for making me take a second look 💃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat: hardware wallets Issues or features related to unlocking or sending with a hardware wallet. type: issue Items that document a problem or bug with an existing feature.
Projects
None yet
Development

No branches or pull requests

3 participants