Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for Trezor Firmware 1.8.0 bug. #2443

Merged
merged 1 commit into from
Mar 21, 2019
Merged

Fix for Trezor Firmware 1.8.0 bug. #2443

merged 1 commit into from
Mar 21, 2019

Conversation

blurpesec
Copy link
Collaborator

Closes #2439

Description

Fixes Trezor Firmware bug that leads to Safety Check Failed

Changes

  • Change method for initializing Trezor session with config.

Steps to Test

  1. Access account with trezor device on electron developer build yarn run dev:electron
  2. Try to send transaction with Trezor account. Sign and submit transaction.

@blurpesec blurpesec added the status: ready for review Open PR's that are ready for technical review. Replaced with "changes needed" or "ready to merge". label Mar 20, 2019
nickserv
nickserv approved these changes Mar 20, 2019
View reviewed changes
Copy link
Contributor

@nickserv nickserv left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, but still needs QA on Trezor.

@nickserv
Copy link
Contributor

nickserv commented Mar 20, 2019 •
edited
Loading

Thanks for the contribution @andreweximchain! You'll be credited for the commits on GitHub (even though we made the pull request).

@nickserv nickserv added status: ready for qa Open PR's that are ready for QA. Replaced with "changes needed" or "approved by qa" and removed status: ready for review Open PR's that are ready for technical review. Replaced with "changes needed" or "ready to merge". labels Mar 20, 2019
@coveralls
Copy link

Coverage Status

Coverage remained the same at 52.822% when pulling 3f7aa8d on andreweximchain:develop into f7d4d17 on MyCryptoHQ:develop.

@SharonManrique SharonManrique added status: ready to merge Open PR's once approved by technical review and by QA. status: approved by qa Open PR's once approved by QA. and removed status: ready for qa Open PR's that are ready for QA. Replaced with "changes needed" or "approved by qa" labels Mar 21, 2019
@SharonManrique SharonManrique merged commit 48d0bce into MyCryptoHQ:develop Mar 21, 2019
@tayvano tayvano mentioned this pull request Mar 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickserv nickserv nickserv approved these changes

Assignees
No one assigned
Labels
status: approved by qa Open PR's once approved by QA. status: ready to merge Open PR's once approved by technical review and by QA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@blurpesec @nickserv @coveralls @SharonManrique @andreweximchain