Check for appropriate keystore file type on upload #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dternyak
reviewed
Dec 20, 2017
| @@ -18,11 +19,17 @@ function isPassRequired(file: string): boolean { | |||
| return passReq; | |||
| } | |||
|
|
|||
| function isValidFile(rawFile: any): boolean { | |||
There was a problem hiding this comment.
I tried finding the rawFile expected type for file uploads, but couldn't find it either. Would be nice to have the proper typing, but any can do for now.
There was a problem hiding this comment.
Is it not part of the FileReader interface?
|
Confirmed working! 👍
|
dternyak
reviewed
Dec 20, 2017
| const fileType = rawFile.type; | ||
| return fileType === '' || fileType === 'application/json'; | ||
| } | ||
|
|
||
| export default class KeystoreDecrypt extends Component { | ||
| public props: { |
There was a problem hiding this comment.
We use the Component<> pattern for specifying props. Mind updating to match?
|
@aitrean Are you planning on updating the |
|
Apologies, meant to add that and it slipped by me. One moment. |
dternyak
changed the title
wbobeirne
approved these changes
Dec 28, 2017
|
Thank you for the contribution @aitrean! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes MyEtherWallet/MyEtherWallet#590