Offline Polling on WalletDecrypt Mount #684
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dternyak
changed the title
wbobeirne
previously approved these changes
Jan 1, 2018
dternyak
force-pushed
the
fix-poll-offline
branch
from
e7f2889 to
3f0f371
Compare
|
How would you feel about polling online from the start? It'd be nice if when you went to the send view, it didn't suddenly pop in the changes, rather than detecting it before you get there. |
|
Sure, I don't see any issue with that. We're not hitting the nodes to poll for offline connectivity anyway, so I don't see any reason why not to do it starting onload. |
|
MyEtherWallet/MyEtherWallet#785 replaces |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes MyEtherWallet/MyEtherWallet#661