Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/top banner buttons #1715

Merged
merged 7 commits into from
Dec 10, 2019
Merged

Fix/top banner buttons #1715

merged 7 commits into from
Dec 10, 2019

Conversation

hsurf22
Copy link
Contributor

@hsurf22 hsurf22 commented Dec 5, 2019

Bug

  • Updated CHANGELOG.md
  • Add PR label
  • No hard-coded strings
    • Fix top banner buttons style

@hsurf22 hsurf22 self-assigned this Dec 5, 2019
@hsurf22 hsurf22 added Hotfix Ready Tag for when a PR is ready to merge labels Dec 5, 2019
@codecov
Copy link

codecov bot commented Dec 5, 2019

Codecov Report

Merging #1715 into develop will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #1715      +/-   ##
==========================================
- Coverage    14.04%     14%   -0.04%     
==========================================
  Files          429     429              
  Lines        14423   14412      -11     
  Branches      2629    2627       -2     
==========================================
- Hits          2025    2018       -7     
+ Misses       11610   11606       -4     
  Partials       788     788
Impacted Files Coverage Δ
...outs/HomeLayout/components/TopBanner/TopBanner.vue 50% <ø> (ø) ⬆️
...ners/SignMessageContainer/SignMessageContainer.vue 19.04% <0%> (-0.96%) ⬇️
...agerContainer/components/NftDetails/NftDetails.vue 0% <0%> (ø) ⬆️
src/layouts/HardwaresLayout/HardwaresLayout.vue 100% <0%> (ø) ⬆️
...rs/ConfirmationContainer/ConfirmationContainer.vue 14.56% <0%> (+0.07%) ⬆️
...ropDownAddressSelector/DropDownAddressSelector.vue 15.21% <0%> (+0.63%) ⬆️
...ts/InterfaceNetworkModal/InterfaceNetworkModal.vue 64.58% <0%> (+0.64%) ⬆️
...ners/SendOfflineContainer/SendOfflineContainer.vue 11.88% <0%> (+0.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d343c30...391765a. Read the comment docs.

Copy link
Contributor

@gamalielhere gamalielhere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen Shot 2019-12-06 at 11 46 53 AM

@gamalielhere gamalielhere added Bug Issues identified. Should be re-labeled to Fatal, or won't fix based on that and removed Hotfix labels Dec 9, 2019
@gamalielhere gamalielhere self-requested a review December 9, 2019 23:53
@gamalielhere gamalielhere merged commit 2cd47ee into develop Dec 10, 2019
@gamalielhere gamalielhere deleted the fix/top-banner-buttons branch December 10, 2019 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues identified. Should be re-labeled to Fatal, or won't fix based on that Ready Tag for when a PR is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants