Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix footer content wrapping issue #1892

Merged
merged 2 commits into from
Jan 27, 2020
Merged

Fix footer content wrapping issue #1892

merged 2 commits into from
Jan 27, 2020

Conversation

hsurf22
Copy link
Contributor

@hsurf22 hsurf22 commented Jan 22, 2020 •
edited
Loading

Bug

  • Updated CHANGELOG.md
  • Add PR label
    • Fix footer content wrapping issue for some languages
  • No hard-coded strings

Screenshot from 2020-01-21 17-42-13
Screenshot from 2020-01-21 17-42-37
Screenshot from 2020-01-21 17-43-07

@hsurf22 hsurf22 added the UI User interface does not match original design label Jan 22, 2020
@hsurf22 hsurf22 self-assigned this Jan 22, 2020
@codecov
Copy link

codecov bot commented Jan 22, 2020 •
edited
Loading

Codecov Report

Merging #1892 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1892   +/-   ##
========================================
  Coverage    13.42%   13.42%           
========================================
  Files          426      426           
  Lines        14276    14276           
  Branches      2635     2635           
========================================
  Hits          1916     1916           
  Misses       11526    11526           
  Partials       834      834
Impacted Files Coverage Δ
src/containers/FooterContainer/FooterContainer.vue 34.48% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a339aac...97fde5b. Read the comment docs.

@hsurf22 hsurf22 added the Ready Tag for when a PR is ready to merge label Jan 27, 2020
@gamalielhere gamalielhere merged commit 3a08306 into develop Jan 27, 2020
@gamalielhere gamalielhere deleted the ui-fix/footer-layout branch January 27, 2020 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gamalielhere gamalielhere gamalielhere approved these changes

@kvhnuke kvhnuke kvhnuke approved these changes

@gesseekur gesseekur Awaiting requested review from gesseekur

@SteveMieskoski SteveMieskoski Awaiting requested review from SteveMieskoski

Assignees

@hsurf22 hsurf22

Labels
Ready Tag for when a PR is ready to merge UI User interface does not match original design
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hsurf22 @kvhnuke @gamalielhere @mew-bot