Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix links #1963

Merged
merged 7 commits into from
Feb 12, 2020
Merged

Fix links #1963

merged 7 commits into from
Feb 12, 2020

Conversation

gamalielhere
Copy link
Contributor

Bug

  • Updated CHANGELOG.md
  • Add PR label
  • No hard-coded strings

@gamalielhere gamalielhere added Bug Issues identified. Should be re-labeled to Fatal, or won't fix based on that Ready Tag for when a PR is ready to merge labels Feb 11, 2020
@codecov
Copy link

codecov bot commented Feb 11, 2020

Codecov Report

❗ No coverage uploaded for pull request base (develop@3386107). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #1963   +/-   ##
==========================================
  Coverage           ?   13.55%           
==========================================
  Files              ?      425           
  Lines              ?    14284           
  Branches           ?     2640           
==========================================
  Hits               ?     1936           
  Misses             ?    11511           
  Partials           ?      837
Impacted Files Coverage Δ
...rc/layouts/HomeLayout/components/Social/Social.vue 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3386107...c7d9893. Read the comment docs.

@gamalielhere gamalielhere merged commit 4c4724b into develop Feb 12, 2020
@gamalielhere gamalielhere deleted the bug/links-and-cx branch February 12, 2020 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveMieskoski SteveMieskoski SteveMieskoski approved these changes

@gesseekur gesseekur gesseekur approved these changes

@kvhnuke kvhnuke kvhnuke approved these changes

Assignees
No one assigned
Labels
Bug Issues identified. Should be re-labeled to Fatal, or won't fix based on that Ready Tag for when a PR is ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gamalielhere @kvhnuke @gesseekur @SteveMieskoski @mew-bot