Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maker dai build proxy contract fix #1985

Merged
merged 5 commits into from
Feb 19, 2020
Merged

Conversation

SteveMieskoski
Copy link
Contributor

@SteveMieskoski SteveMieskoski commented Feb 18, 2020

Bug

  • Updated CHANGELOG.md
  • Add PR label
  • No hard-coded strings

@SteveMieskoski SteveMieskoski added the Ready Tag for when a PR is ready to merge label Feb 18, 2020
@codecov
Copy link

codecov bot commented Feb 18, 2020

Codecov Report

Merging #1985 into develop will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1985      +/-   ##
===========================================
- Coverage    13.48%   13.46%   -0.03%     
===========================================
  Files          425      425              
  Lines        14302    14324      +22     
  Branches      2641     2643       +2     
===========================================
  Hits          1929     1929              
- Misses       11536    11558      +22     
  Partials       837      837
Impacted Files Coverage Δ
src/layouts/InterfaceLayout/InterfaceLayout.vue 0% <0%> (ø) ⬆️
src/dapps/ManageENS/ManageENS.vue 6.41% <0%> (-0.11%) ⬇️
...eCommitmentContainer/CreateCommitmentContainer.vue 0% <0%> (ø) ⬆️
...out/components/InterfaceTokens/InterfaceTokens.vue 17.34% <0%> (-1.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33189a0...231cdd9. Read the comment docs.

@gamalielhere gamalielhere merged commit dbf1ea9 into develop Feb 19, 2020
@gamalielhere gamalielhere deleted the bug/makerDai-build-proxy-fix branch February 19, 2020 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready Tag for when a PR is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants