Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hotfix release/v5.4.1-hotfix.1 | fix for mewconnect disconnect #2064

Merged
merged 12 commits into from
Mar 6, 2020
Merged

hotfix release/v5.4.1-hotfix.1 | fix for mewconnect disconnect #2064

merged 12 commits into from
Mar 6, 2020

Conversation

SteveMieskoski
Copy link
Contributor

@SteveMieskoski SteveMieskoski commented Mar 6, 2020 •
edited by kvhnuke
Loading

Release

Bug

  • Updated CHANGELOG.md
  • Add PR label
  • No hard-coded strings

@SteveMieskoski SteveMieskoski added Bug Issues identified. Should be re-labeled to Fatal, or won't fix based on that Ready Tag for when a PR is ready to merge v5 for PRs for v5 labels Mar 6, 2020
@kvhnuke kvhnuke changed the title fix for mewconnect disconnect hotfix release/v5.4.1-hotfix.1 | fix for mewconnect disconnect Mar 6, 2020
@kvhnuke kvhnuke changed the base branch from develop to master March 6, 2020 05:54
@codecov
Copy link

codecov bot commented Mar 6, 2020 •
edited
Loading

Codecov Report

Merging #2064 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2064   +/-   ##
=======================================
  Coverage   14.49%   14.49%           
=======================================
  Files         442      442           
  Lines       14890    14890           
  Branches     2742     2742           
=======================================
  Hits         2158     2158           
  Misses      11888    11888           
  Partials      844      844

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2f9de5...6765ee7. Read the comment docs.

@kvhnuke kvhnuke merged commit 0662b18 into master Mar 6, 2020
@kvhnuke kvhnuke deleted the bug/mewconnect-disconnect branch March 6, 2020 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvhnuke kvhnuke kvhnuke approved these changes

@gesseekur gesseekur gesseekur approved these changes

@gamalielhere gamalielhere gamalielhere approved these changes

Assignees
No one assigned
Labels
Bug Issues identified. Should be re-labeled to Fatal, or won't fix based on that Ready Tag for when a PR is ready to merge v5 for PRs for v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SteveMieskoski @kvhnuke @gesseekur @gamalielhere @mew-bot