Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug/cool-and-bcvault #2175

Merged
merged 6 commits into from
Mar 30, 2020
Merged

bug/cool-and-bcvault #2175

merged 6 commits into from
Mar 30, 2020

Conversation

gamalielhere
Copy link
Contributor

Bug

  • Updated CHANGELOG.md
  • Add PR label
  • No hard-coded strings

@codecov
Copy link

codecov bot commented Mar 27, 2020 •
edited
Loading

Codecov Report

Merging #2175 into develop will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2175   +/-   ##
========================================
  Coverage    13.76%   13.76%           
========================================
  Files          458      458           
  Lines        19066    19066           
  Branches      3271     3291   +20     
========================================
  Hits          2624     2624           
  Misses       15608    15608           
  Partials       834      834

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e662e8a...30ef49d. Read the comment docs.

@gamalielhere gamalielhere added Bug Issues identified. Should be re-labeled to Fatal, or won't fix based on that Ready Tag for when a PR is ready to merge labels Mar 27, 2020
@gamalielhere gamalielhere linked an issue Mar 27, 2020 that may be closed by this pull request
Cool wallet connect problem #2177
Closed
@gamalielhere gamalielhere merged commit ac3e6c4 into develop Mar 30, 2020
@gamalielhere gamalielhere deleted the bug/cool-and-bcvault branch March 30, 2020 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveMieskoski SteveMieskoski SteveMieskoski approved these changes

@gesseekur gesseekur gesseekur approved these changes

@kvhnuke kvhnuke kvhnuke approved these changes

Assignees
No one assigned
Labels
Bug Issues identified. Should be re-labeled to Fatal, or won't fix based on that Ready Tag for when a PR is ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cool wallet connect problem
5 participants
@gamalielhere @kvhnuke @gesseekur @SteveMieskoski @mew-bot