polishing refinements to dex.ag #2323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveMieskoski
requested review from
gamalielhere,
gesseekur and
kvhnuke
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #2323 +/- ##
===========================================
- Coverage 12.90% 12.90% -0.01%
===========================================
Files 483 483
Lines 20096 20105 +9
Branches 3406 3412 +6
===========================================
+ Hits 2594 2595 +1
- Misses 16632 16638 +6
- Partials 870 872 +2
Continue to review full report at Codecov.
|
…ments # Conflicts: # fetchLists/lists/tokens.json
SteveMieskoski
added
Ready
gamalielhere
approved these changes
May 1, 2020
gesseekur
reviewed
May 1, 2020
| @@ -313,6 +314,17 @@ export default class DexAg { | |||
| data: tradeDetails.trade.data, | |||
| value: tradeDetails.trade.value | |||
| }; | |||
| if ( | |||
| tradeDetails.metadata.gasPrice && | |||
| swapDetails.provider === 'bancor' && | |||
There was a problem hiding this comment.
I think we don't like to compare values to strings ??
gesseekur
approved these changes
May 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Devop