Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug/sentry fixes/jess #2396

Merged
merged 16 commits into from
May 27, 2020
Merged

Bug/sentry fixes/jess #2396

merged 16 commits into from
May 27, 2020

Conversation

gesseekur
Copy link
Contributor

@gesseekur gesseekur commented May 21, 2020 •
edited
Loading

@codecov
Copy link

codecov bot commented May 21, 2020 •
edited
Loading

Codecov Report

Merging #2396 into develop will increase coverage by 0.00%.
The diff coverage is 12.50%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2396   +/-   ##
========================================
  Coverage    13.99%   13.99%           
========================================
  Files          471      471           
  Lines        18606    18610    +4     
  Branches      3128     3132    +4     
========================================
+ Hits          2604     2605    +1     
- Misses       15187    15188    +1     
- Partials       815      817    +2
Impacted Files Coverage Δ
src/dapps/Aave/Aave.vue 12.83% <ø> (ø)
...components/ConfirmationModal/ConfirmationModal.vue 45.54% <ø> (ø)
...ntainers/ManageENSContainer/ManageENSContainer.vue 5.60% <0.00%> (ø)
src/dapps/ManageENS/supportedTxt.js 22.72% <0.00%> (-2.28%) ⬇️
...ontractContainer/InteractWithContractContainer.vue 24.06% <0.00%> (-0.19%) ⬇️
...ave/containers/ActionContainer/ActionContainer.vue 55.42% <33.33%> (+0.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2b7367...a1efe31. Read the comment docs.

@gesseekur gesseekur added Bug Issues identified. Should be re-labeled to Fatal, or won't fix based on that v5 for PRs for v5 WIP work in proress labels May 21, 2020
@gesseekur gesseekur added Ready Tag for when a PR is ready to merge and removed WIP work in proress labels May 26, 2020
@gamalielhere gamalielhere merged commit bd54d15 into develop May 27, 2020
@gamalielhere gamalielhere deleted the bug/sentry-fixes/jess branch May 27, 2020 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveMieskoski SteveMieskoski SteveMieskoski approved these changes

@gamalielhere gamalielhere gamalielhere approved these changes

@kvhnuke kvhnuke kvhnuke approved these changes

Assignees
No one assigned
Labels
Bug Issues identified. Should be re-labeled to Fatal, or won't fix based on that Ready Tag for when a PR is ready to merge v5 for PRs for v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gesseekur @kvhnuke @gamalielhere @SteveMieskoski @mew-bot