Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug/remove-view-wallet #2454

Merged
merged 2 commits into from
Jun 18, 2020
Merged

bug/remove-view-wallet #2454

merged 2 commits into from
Jun 18, 2020

Conversation

gamalielhere
Copy link
Contributor

Bug

  • Updated CHANGELOG.md
  • Add PR label
  • No hard-coded strings

@gamalielhere gamalielhere added Bug Issues identified. Should be re-labeled to Fatal, or won't fix based on that Ready Tag for when a PR is ready to merge labels Jun 18, 2020
@gamalielhere gamalielhere changed the title Remove view wallet layout bug/remove-view-wallet Jun 18, 2020
@codecov
Copy link

codecov bot commented Jun 18, 2020 •
edited
Loading

Codecov Report

Merging #2454 into develop will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2454      +/-   ##
===========================================
+ Coverage    13.88%   13.98%   +0.09%     
===========================================
  Files          475      474       -1     
  Lines        18845    18711     -134     
  Branches      3164     3153      -11     
===========================================
  Hits          2616     2616              
+ Misses       15399    15265     -134     
  Partials       830      830
Impacted Files Coverage Δ
src/containers/FooterContainer/FooterContainer.vue 37.03% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 033952d...1cdbd11. Read the comment docs.

@gamalielhere gamalielhere added the v5 for PRs for v5 label Jun 18, 2020
@kvhnuke kvhnuke merged commit d070498 into develop Jun 18, 2020
@kvhnuke kvhnuke deleted the bug/remove-view-wallet branch June 18, 2020 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveMieskoski SteveMieskoski SteveMieskoski approved these changes

@kvhnuke kvhnuke kvhnuke approved these changes

@gesseekur gesseekur Awaiting requested review from gesseekur

Assignees
No one assigned
Labels
Bug Issues identified. Should be re-labeled to Fatal, or won't fix based on that Ready Tag for when a PR is ready to merge v5 for PRs for v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gamalielhere @kvhnuke @SteveMieskoski @mew-bot