Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/tokens #2500

Merged
merged 6 commits into from
Jul 7, 2020
Merged

Bug/tokens #2500

merged 6 commits into from
Jul 7, 2020

Conversation

gamalielhere
Copy link
Contributor

Bug

  • Updated CHANGELOG.md
  • Add PR label
  • No hard-coded strings

@gamalielhere gamalielhere added Bug Issues identified. Should be re-labeled to Fatal, or won't fix based on that Ready Tag for when a PR is ready to merge labels Jun 30, 2020
@codecov
Copy link

codecov bot commented Jun 30, 2020

Codecov Report

Merging #2500 into develop will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2500      +/-   ##
===========================================
- Coverage    13.95%   13.95%   -0.01%     
===========================================
  Files          469      469              
  Lines        18733    18735       +2     
  Branches      3173     3174       +1     
===========================================
  Hits          2614     2614              
- Misses       15285    15287       +2     
  Partials       834      834              
Impacted Files Coverage Δ
...sionBrowserAction/components/CxFooter/CxFooter.vue 40.00% <ø> (ø)
...rc/layouts/HomeLayout/components/Social/Social.vue 100.00% <ø> (ø)
src/layouts/InterfaceLayout/InterfaceLayout.vue 0.00% <0.00%> (ø)
...out/components/InterfaceTokens/InterfaceTokens.vue 17.03% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50815a5...360ebfa. Read the comment docs.

@gamalielhere gamalielhere merged commit a516809 into develop Jul 7, 2020
@gamalielhere gamalielhere deleted the bug/tokens branch July 7, 2020 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues identified. Should be re-labeled to Fatal, or won't fix based on that Ready Tag for when a PR is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants