Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/lend migrator #2606

Merged
merged 23 commits into from
Oct 8, 2020
Merged

Feature/lend migrator #2606

merged 23 commits into from
Oct 8, 2020

Conversation

gesseekur
Copy link
Contributor

@gesseekur gesseekur commented Sep 30, 2020

Feature

  • Updated CHANGELOG.md
  • Add PR label
  • No hard-coded strings

@gesseekur gesseekur added WIP work in proress v5 for PRs for v5 labels Sep 30, 2020
@codecov
Copy link

codecov bot commented Oct 2, 2020

Codecov Report

Merging #2606 into develop will decrease coverage by 0.03%.
The diff coverage is 9.68%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2606      +/-   ##
===========================================
- Coverage    13.95%   13.92%   -0.04%     
===========================================
  Files          469      475       +6     
  Lines        18735    19113     +378     
  Branches      3174     3248      +74     
===========================================
+ Hits          2614     2661      +47     
- Misses       15287    15591     +304     
- Partials       834      861      +27     
Impacted Files Coverage Δ
src/builds/configs/base-routes.js 0.00% <0.00%> (ø)
src/builds/mewcx/app.vue 0.00% <0.00%> (ø)
src/builds/mewcx/browserAction/app.vue 0.00% <0.00%> (ø)
src/builds/mewcx/cxHelpers/background.js 0.00% <0.00%> (ø)
...s/mewcx/cxHelpers/backgroundEvents/web3-sign-tx.js 0.00% <0.00%> (ø)
src/builds/web/app.vue 0.00% <ø> (ø)
src/components/Card1/Card1.vue 0.00% <ø> (ø)
...mponents/PageTitleComponent/PageTitleComponent.vue 0.00% <ø> (ø)
.../ConfirmCollectionModal/ConfirmCollectionModal.vue 42.85% <ø> (ø)
src/containers/FaqsContainer/FaqsContainer.vue 100.00% <ø> (ø)
... and 79 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04e69bf...1c572ed. Read the comment docs.

@gesseekur gesseekur added Ready Tag for when a PR is ready to merge and removed WIP work in proress labels Oct 2, 2020
@gamalielhere gamalielhere merged commit 5e00b74 into develop Oct 8, 2020
@gamalielhere gamalielhere deleted the feature/lend-migrator branch October 8, 2020 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready Tag for when a PR is ready to merge v5 for PRs for v5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants