Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devop/network logo #49

Closed
wants to merge 22 commits into from
Closed

Devop/network logo #49

wants to merge 22 commits into from

Conversation

gamalielhere
Copy link
Contributor

Devop

  • Updated CHANGELOG.md
  • Add PR label

@gamalielhere gamalielhere added Devop Devop tasks Ready Tag for when a PR is ready to merge labels Aug 15, 2018
@gamalielhere gamalielhere changed the base branch from master to develop August 15, 2018 17:43
@gamalielhere
Copy link
Contributor Author

@hackmod I also added your network logos here on the upcoming V5 of MEW if you don't mind. Let me know if you do and I'll close and cancel this PR.

@codecov
Copy link

codecov bot commented Aug 15, 2018

Codecov Report

Merging #49 into develop will decrease coverage by 0.25%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop     #49      +/-   ##
==========================================
- Coverage        4%   3.74%   -0.26%     
==========================================
  Files          377     422      +45     
  Lines         1625    1734     +109     
  Branches       107     104       -3     
==========================================
  Hits            65      65              
- Misses        1551    1660     +109     
  Partials         9       9
Impacted Files Coverage Δ
...t/components/InterfaceNetwork/InterfaceNetwork.vue 0% <ø> (ø) ⬆️
src/configs/networks/nodes/exp.js 0% <0%> (ø)
src/configs/networks/types/ETH.js 0% <0%> (ø)
src/configs/networks/nodes/eosc.js 0% <0%> (ø)
...out/components/InterfaceTokens/InterfaceTokens.vue 0% <0%> (ø) ⬆️
src/configs/networks/types/EXP.js 0% <0%> (ø)
src/configs/networks/types/UBQ.js 0% <0%> (ø)
src/configs/networks/nodes/etsc.js 0% <0%> (ø)
src/configs/networks/nodes/kov-infura.js 0% <0%> (ø)
src/configs/networks/nodes/akroma.js 0% <0%> (ø)
... and 89 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec060ea...15ca6c8. Read the comment docs.

@hackmod
Copy link
Contributor

hackmod commented Aug 15, 2018

@gamalielhere I don't mind. thank you for your great work!

@gamalielhere gamalielhere mentioned this pull request Aug 17, 2018
1 task
@gamalielhere gamalielhere deleted the devop/network-logo branch August 17, 2018 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Devop Devop tasks Ready Tag for when a PR is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants