Explicitly mark another library as static #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnyOldName3
changed the title
I've also figured out why this problem wasn't obvious. It only happens when someone's used the CMake-standard BUILD_SHARED_LIBS option, which controls the default behaviour for add_library. When MyGUI is built as a standalone project, this won't be set (unless someone's done it manually) so it's fine. When MyGUI is built as part of a larger project (e.g. package manager like vcpkg or CPM, or as a nested project with FetchContent), it's likely to have been set by something else. It might be a good idea to pick the default value of MYGUI_STATIC to match BUILD_SHARED_LIBS if it's set, but I've not done that in this PR.
AnyOldName3
force-pushed
the
and-another-one
branch
from
53526a1 to
32e39f8
Compare
|
A little more context: This is a follow-up to #270 as it was pointed out to me by a vcpkg person that the tools (which I'd not built when I tested the other PR) still didn't build. |
AnyOldName3
added a commit
to AnyOldName3/vcpkg
that referenced
this pull request
Oct 29, 2024
Available upstream as MyGUI/mygui#271, which isn't merged when I'm writing this, but likely will be by the time anyone reviews this PR again.
7 tasks
|
Nice catch, thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've also figured out why this problem wasn't obvious. It only happens when someone's used the CMake-standard
BUILD_SHARED_LIBSoption, which controls the default behaviour foradd_library. When MyGUI is built as a standalone project, this won't be set (unless someone's done it manually) so it's fine. However, when MyGUI is built as part of a larger project (e.g. package manager like vcpkg or CPM, or as a nested project withFetchContentor as a submodule), it's likely to have been set by something else.It might be a good idea to pick the default value of
MYGUI_STATICto matchBUILD_SHARED_LIBSif it's set, but I've not done that in this PR.