Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make method addStyleElementToDocument protected instead of private #103

Closed
bryangreen opened this issue Oct 29, 2014 · 1 comment · Fixed by #105
Closed

Make method addStyleElementToDocument protected instead of private #103

bryangreen opened this issue Oct 29, 2014 · 1 comment · Fixed by #105
Milestone
1.0.0

Comments

@bryangreen
Copy link

I need use of this in another class that extends the Emogrifier. Please change this method to protected so that it can be accessed.
@oliverklee oliverklee added this to the 1.0.0 milestone Oct 30, 2014
oliverklee added a commit that referenced this issue Oct 30, 2014
@oliverklee
[TASK] Make method addStyleElementToDocument protected
11b817c 
Closes: #103
@oliverklee oliverklee mentioned this issue Oct 30, 2014
Merged
@bryangreen
Copy link
Author

Thanks! Looking forward to rev 1.0.0. Cheers.

@oliverklee oliverklee mentioned this issue Dec 11, 2014
Closed
@JakeQZ JakeQZ mentioned this issue Nov 30, 2021
Closed
@oliverklee oliverklee changed the title Make method 'addStyleElementToDocument' protected instead of private Make method addStyleElementToDocument protected instead of private Sep 14, 2024
@oliverklee oliverklee changed the title Make method addStyleElementToDocument protected instead of private Make method addStyleElementToDocument protected instead of private Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

[TASK] Make method addStyleElementToDocument protected MyIntervals/emogrifier
2 participants
@bryangreen @oliverklee