Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update supported selectors in README #723

Closed
JakeQZ opened this issue Sep 26, 2019 · 0 comments · Fixed by #753
Closed

Update supported selectors in README #723

JakeQZ opened this issue Sep 26, 2019 · 0 comments · Fixed by #753
Assignees
@JakeQZ
Labels
documentation unit tests needed
Milestone
3.0.0

Comments

@JakeQZ
Copy link
Contributor

JakeQZ commented Sep 26, 2019

Under the heading “Supported CSS selectors” and also the last bullet point under “Caveats”.

Now that we use the Symfony CssSelector component, most selectors (except pseudo-elements and dynamic pseudo-classes) are supported. The only exception I'm aware of is :nth-of-type without a type (i.e., e.g. p:nth-of-type works as expected but :nth-of-type alone behaves as :nth-child) – though :first-of-type, :last-of-type and :nth-last-of-type are probably similarly not fully supported.

It should probably also be noted that rules for impossible-to-inline selectors (pseudo-elements and dynamic pseudo-classes) will be copied to a <style> element so that they will work on email clients that support them.

We may however need additional tests to confirm ‘case-insensitive attribute value’ and ‘general sibling’ are indeed now supported, before removing them from the ‘not supported’ list.
@JakeQZ JakeQZ added this to the 3.0.0 milestone Sep 26, 2019
@JakeQZ JakeQZ self-assigned this Sep 29, 2019
JakeQZ added a commit that referenced this issue Sep 29, 2019
@JakeQZ
[TASK] Test universal selector with combinators
b05b52b 
Also added “broken: …” placeholder comments for tests that would currently fail
due to lack of support, and updated the README to reflect the level of support
for the universal selector.

Part of #723.
@JakeQZ JakeQZ mentioned this issue Sep 29, 2019
Merged
oliverklee pushed a commit that referenced this issue Sep 29, 2019
@JakeQZ @oliverklee
[TASK] Test universal selector with combinators (#743)
b752dac 
Also added “broken: …” placeholder comments for tests that would currently fail
due to lack of support, and updated the README to reflect the level of support
for the universal selector.

Part of #723.
JakeQZ added a commit that referenced this issue Sep 29, 2019
@JakeQZ
[TASK] Placeholder for case-insensitive attribute tests
31a67b3 
Added “broken: …” comments as placeholders for case-insensitive attribute
selector tests that would currently fail due to lack of support.  This indicates
that the lack of support has been confirmed (e.g. with the Symfony CssSelector
component).

Part of #723.
@JakeQZ JakeQZ mentioned this issue Sep 29, 2019
Merged
oliverklee pushed a commit that referenced this issue Sep 29, 2019
@JakeQZ @oliverklee
[TASK] Placeholder for case-insensitive attribute tests (#744)
c682802 
Added “broken: …” comments as placeholders for case-insensitive attribute
selector tests that would currently fail due to lack of support.  This indicates
that the lack of support has been confirmed (e.g. with the Symfony CssSelector
component).

Part of #723.
This was referenced Sep 29, 2019
Closed
Closed
JakeQZ added a commit that referenced this issue Sep 29, 2019
@JakeQZ
[TASK] Update supported pseudo-classes in README
3337360 
This updates the list to those that are supported **and** for which we have
tests.  There are some others that are (probably) supported but for which we
don’t yet have any tests – see #747 – these have not been added to the list …
yet.

Part of #723.
@JakeQZ JakeQZ mentioned this issue Sep 29, 2019
Merged
oliverklee pushed a commit that referenced this issue Sep 29, 2019
@JakeQZ @oliverklee
[TASK] Update supported pseudo-classes in README (#749)
db22527 
This updates the list to those that are supported **and** for which we have
tests.  There are some others that are (probably) supported but for which we
don’t yet have any tests – see #747 – these have not been added to the list …
yet.

Part of #723.
JakeQZ added a commit that referenced this issue Sep 30, 2019
@JakeQZ
[TASK] Update unsupported selectors & caveats in README
5b32f24 
- Move pseudo-elements and dynamic pseudo-classes to separate list of ‘what is
  copied to a `<style>` element because it can’t be inlined’, removing
  no-longer-relevant “some of them will never be supported”;
- Mention the pitfalls of the `…-of-type()` selectors in the ‘not implemented
  yet’ section;
- Mention that any (static) pseudo-classes not claimed to be supported will have
  their rules preserved and copied to a `<style>` element.
- Correct “@media queries” to “`@media` rules” and remove obsolete “now”;
- Mention that declarations in `@media` rules may need `!important`, with
  example;
- Add caveat note about pseudo-elements and dynamic pseudo-classes being treated
  similarly to `@media` rules, with the same possible need for `!important`;
- Replace nonsensical observation about `<link>` elements with something more
  appropriate;
- Remove superseded caveat about only supporting CSS 1 and a few CSS 2
  selectors.

Resolves #723.  #747 and #748 have been opened to cover remaining issues.
JakeQZ added a commit that referenced this issue Sep 30, 2019
@JakeQZ
[TASK] Update unsupported selectors & caveats in README
270ba71 
- Move pseudo-elements and dynamic pseudo-classes to separate list of ‘what is
  copied to a `<style>` element because it can’t be inlined’, removing
  no-longer-relevant “some of them will never be supported”;
- Mention the pitfalls of the `…-of-type()` selectors in the ‘not implemented
  yet’ section;
- Mention that any (static) pseudo-classes not claimed to be supported will have
  their rules preserved and copied to a `<style>` element.
- Correct “@media queries” to “`@media` rules” and remove obsolete “now”;
- Mention that declarations in `@media` rules may need `!important`, with
  example;
- Add caveat note about pseudo-elements and dynamic pseudo-classes being treated
  similarly to `@media` rules, with the same possible need for `!important`;
- Replace nonsensical observation about `<link>` elements with something more
  appropriate;
- Remove superseded caveat about only supporting CSS 1 and a few CSS 2
  selectors.

Resolves #723.  #747 and #748 have been opened to cover remaining issues.
JakeQZ added a commit that referenced this issue Sep 30, 2019
@JakeQZ
[TASK] Update unsupported selectors & caveats in README
d1f04fb 
- Move pseudo-elements and dynamic pseudo-classes to separate list of ‘what is
  copied to a `<style>` element because it can’t be inlined’, removing
  no-longer-relevant “some of them will never be supported”;
- Mention the pitfalls of the `…-of-type()` selectors in the ‘not implemented
  yet’ section;
- Mention that any (static) pseudo-classes not claimed to be supported will have
  their rules preserved and copied to a `<style>` element.
- Correct “@media queries” to “`@media` rules” and remove obsolete “now”;
- Mention that declarations in `@media` rules may need `!important`, with
  example;
- Add caveat note about pseudo-elements and dynamic pseudo-classes being treated
  similarly to `@media` rules, with the same possible need for `!important`;
- Replace nonsensical observation about `<link>` elements with something more
  appropriate;
- Remove superseded caveat about only supporting CSS 1 and a few CSS 2
  selectors.

Resolves #723.  #747 and #748 have been opened to cover remaining issues.
@JakeQZ JakeQZ mentioned this issue Sep 30, 2019
Merged
oliverklee pushed a commit that referenced this issue Sep 30, 2019
@JakeQZ @oliverklee
[TASK] Update unsupported selectors & caveats in README (#753)
39789d6 
- Move pseudo-elements and dynamic pseudo-classes to separate list of ‘what is
  copied to a `<style>` element because it can’t be inlined’, removing
  no-longer-relevant “some of them will never be supported”;
- Mention the pitfalls of the `…-of-type()` selectors in the ‘not implemented
  yet’ section;
- Mention that any (static) pseudo-classes not claimed to be supported will have
  their rules preserved and copied to a `<style>` element.
- Correct “@media queries” to “`@media` rules” and remove obsolete “now”;
- Mention that declarations in `@media` rules may need `!important`, with
  example;
- Add caveat note about pseudo-elements and dynamic pseudo-classes being treated
  similarly to `@media` rules, with the same possible need for `!important`;
- Replace nonsensical observation about `<link>` elements with something more
  appropriate;
- Remove superseded caveat about only supporting CSS 1 and a few CSS 2
  selectors.

Resolves #723.  #747 and #748 have been opened to cover remaining issues.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JakeQZ JakeQZ

Labels
documentation unit tests needed
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

[TASK] Update unsupported selectors & caveats in README MyIntervals/emogrifier
1 participant
@JakeQZ