Support ci:php:lint on Windows
#740
Comments
|
appears to work under gitbash. |
|
@SignpostMarv Just wanted to let you know that I greatly appreciate you having started to contribute to Emogrifier with pull requests and ticket comments. ❤️ Keep 'em coming! 🍪 |
I'm just using the command prompt in Windows, where all other commands work fine. I could start using gitbash. But I think this extra requirement would discourage people from contributing, so I'd prefer to have something that will work on all environments. |
SignpostMarv
added a commit
to SignpostMarv/emogrifier
that referenced
this issue
Oct 1, 2019
…t using the git for windows cli (git bash), fixes MyIntervals#740
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The Composer script for
php -luses a *nix-specific command and does not work on Windows.We should find a way of allowing developers to run the whole of the
ciscript on whatever platform they're using. (I'm guessing it works OK on macOS as that's Unix-based. None of the other parts of theciscript have an issue on Windows.)The text was updated successfully, but these errors were encountered: