[BUGFIX] Emogrifier: Support HTML5 void tags
#653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support to `Emogrifier` for HTML5 self-closing tags not recognized as such by PHP’s `DOMDocument` implementation. This is a port of the equivalent changes made for `AbstractHtmlProcessor` in #651, with some differences in the tests: - The tests employ `emogrify` and `emogrifyBodyContent` rather than `render` and `renderBodyContent`, as the latter are not public methods; - Since, by default, `emogrify` removes `<wbr>` elements, an additional call to `removeUnprocessableHtmlTag()` is required in each test’s set-up; - An additional separate test confirms `removeUnprocessableHtmlTag('wbr')` behaves as expected.
oliverklee
approved these changes
Mar 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support to
Emogrifierfor HTML5 self-closing tags not recognized as suchby PHP’s
DOMDocumentimplementation.This is a port of the equivalent changes made for
AbstractHtmlProcessorin #651, with some differences in the tests:
emogrifyandemogrifyBodyContentrather thanrenderandrenderBodyContent, as the latter are not public methods;emogrifyremoves<wbr>elements, an additional call toremoveUnprocessableHtmlTag()is required in each test’s set-up;removeUnprocessableHtmlTag('wbr')behaves as expected.