Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Test :not(.class) (as entire selector) #725

Merged
merged 2 commits into from
Sep 28, 2019
Merged

Conversation

JakeQZ
Copy link
Contributor

@JakeQZ JakeQZ commented Sep 27, 2019

Also :not(type). There were placeholder comments “broken: …” for these tests.
The selectors are now supported by virtue of using the Symfony CssSelector
component.

Resolves #469.

Also `:not(type)`.  There were placeholder comments “broken: …” for these tests.
The selectors are now supported by virtue of using the Symfony CssSelector
component.

Resolves #469.
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@oliverklee oliverklee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good. In the changelog, we can avoid a redirect with a change.

@JakeQZ
Copy link
Contributor Author

JakeQZ commented Sep 27, 2019

Corrected the CHANGELOG URL and repushed.

@oliverklee oliverklee merged commit 9ba55cb into master Sep 28, 2019
@oliverklee oliverklee deleted the test/not-class branch September 28, 2019 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support :not(.class)
2 participants