-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLEANUP] adding & utilising composer sort-packages #788
[CLEANUP] adding & utilising composer sort-packages #788
Conversation
@SignpostMarv A request for future commit message (I'll update this PR's message on merging): After the code for the type of change ([FEATURE], [BUGFIX], [CLEANUP] or [TASK]), please start the commit subject as a continuation of "This commit will …", e.g, "Add …" or "Fix …". Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
or
? |
@SignpostMarv I don't quite understand your question. Maybe an example for a (fictional) single commit message will help: (Subject) [BUGFIX] Warn if the HTML is empty (Description) Previously, inlining CSS for empty HTML was possible, although this indicates that the inliner was called with broken data. Now the |
@SignpostMarv For more details, I can recommend this blog post: https://chris.beams.io/posts/git-commit/ |
ah; I very rarely use extended commit messages. there's a butt load of commits coming on the rebased #778 branch: will rebase these once I'm done to reword them appropriately before force-pushing. |
One-liners are perfectly fine as long as there is nothing useful to add in addition to the commit message subject/heading. |
mutli-liners when resolving psalm issues may prove useful to those unfamiliar with psalm typehinting syntax. |
The title of the initial commit is potentially most important. When squashing-and-merging, we can edit the commit message, but it will typically begin with that from the first commit. If you encounter any issues rebasing, you might like to reference my post at #373 (comment) for guidance, and possibly @oliverklee's at #708 (comment) if anything goes awry. Thanks again for contributing 🥰 |
No description provided.