Extract font-face rules and inject into head <styles> element #870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarongerig
force-pushed
the
feature/extract-font-face-rules
branch
from
1f1da9a
to
df1f0b3
Compare
oliverklee
requested changes
May 25, 2020
oliverklee
requested changes
May 25, 2020
added 5 commits
May 25, 2020 17:00
… font-family and src descriptors
JakeQZ
reviewed
May 25, 2020
JakeQZ
approved these changes
May 26, 2020
There was a problem hiding this comment.
LGTM though I'll let @oliverklee give it a final once over before committing. Thanks @aarongerig for contributing.
|
Great – thanks for reviewing @JakeQZ ! |
oliverklee
requested changes
May 27, 2020
oliverklee
approved these changes
May 28, 2020
oliverklee
approved these changes
May 28, 2020
|
Awesome, thanks so much guys! 🙏🏻 |
|
@oliverklee Are you planning to publish a new release, which includes this feature soon? :) |
|
Yes: #874 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the follow up to issue #869.
The code was tested on one of my current projects and there all
@font-facerules were successfully extracted and injected into the<styles>element.Let me know if I can do something else to get this into master.