[BUGFIX] Fix a nonsensical code example in the README #935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeQZ
requested changes
Nov 22, 2020
CHANGELOG.md
Outdated
| @@ -36,6 +36,9 @@ This project adheres to [Semantic Versioning](https://semver.org/). | |||
| ([#880](https://github.com/MyIntervals/emogrifier/pull/880)) | |||
|
|
|||
| ### Fixed | |||
| - Fix a nonsensical code example in the README | |||
| ([#920](https://github.com/MyIntervals/emogrifier/pull/920), | |||
There was a problem hiding this comment.
URL should contain issues rather than pull (if we want to reference the issue as well as the PR).
There was a problem hiding this comment.
Fixed, rebased and repushed.
oliverklee
force-pushed
the
bugfix/docs-example
branch
from
cb7750f
to
f5840b1
Compare
JakeQZ
approved these changes
Nov 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #920