Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] Allow line feeds within <html> tag #987

Merged
merged 1 commit into from
Apr 9, 2021
Merged

[BUGFIX] Allow line feeds within <html> tag #987

merged 1 commit into from
Apr 9, 2021

Conversation

JakeQZ
Copy link
Contributor

@JakeQZ JakeQZ commented Apr 8, 2021

Also add tests to confirm that the <html> tag's attributes are preserved, and
a duplicate <html> tag does not arise.

Resolves #981.

@JakeQZ
[BUGFIX] Allow line feeds within <html> tag
d17d71e 
Also add tests to confirm that the `<html>` tag's attributes are preserved, and
a duplicate `<html>` tag does not arise.

Resolves #981.
@JakeQZ JakeQZ added the bug label Apr 8, 2021
@JakeQZ JakeQZ added this to the 6.0.0 milestone Apr 8, 2021
@JakeQZ JakeQZ self-assigned this Apr 8, 2021
@JakeQZ
Copy link
Contributor Author

JakeQZ commented Apr 8, 2021

I've not gone as far as attempting to cater for rogue tags like <htmler> or <xhtml>, which would require more tests, and seem pretty unlikely to arise in any real world scenario, given that no such tag names are defined by W3C.

@oliverklee oliverklee merged commit 1302d00 into main Apr 9, 2021
@oliverklee oliverklee deleted the bugfix/html-tag-lf branch April 9, 2021 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverklee oliverklee oliverklee approved these changes

@zoliszabo zoliszabo Awaiting requested review from zoliszabo

Assignees

@JakeQZ JakeQZ

Labels
bug
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.

Multiline <head> tag not matched?
2 participants
@JakeQZ @oliverklee