Skip to content
This repository has been archived by the owner on Aug 1, 2024. It is now read-only.

Manifest file creating wrong structure #16

Closed
raymondflores opened this issue Aug 2, 2018 · 3 comments · Fixed by #17
Closed

Manifest file creating wrong structure #16

raymondflores opened this issue Aug 2, 2018 · 3 comments · Fixed by #17

Comments

@raymondflores
Copy link
Contributor

raymondflores commented Aug 2, 2018

Manifest file creation is returning
{ "website.json": "hash", ... }

Instead it should return
{ "website.json": { hashType: 'sha512', hashValue: 'hash' }, ... }

I created the fix but im not allowed to push to a branch and therefore cant create a pull request

@kobim
Copy link
Member

kobim commented Aug 3, 2018

Hi @raymondflores , thanks for letting me know about the new changes to manifest.json.

I've seen you already forked this repository, so please push your fixes to your fork and open a pull request (don't forget about tests please) with reference to this issue.
For more information about forking, you can use GitHub's tutorial - https://guides.github.com/activities/forking/

@raymondflores
Copy link
Contributor Author

raymondflores commented Aug 3, 2018

@kobim I wrote the test coverage for utils which is all i changed. But when i run npm test I get this error
SecurityError: localStorage is not available for opaque origins at Window.get localStorage [as localStorage] (../../../../usr/local/lib/node_modules/jest/node_modules/jsdom/lib/jsdom/browser/Window.js:257:15) at Array.forEach (native)

@kobim
Copy link
Member

kobim commented Aug 3, 2018

See jsdom/jsdom#2304 for more details about your error (although the current jest version in the project isn't affected by this problem, so I'm not sure why you are seeing this.)

@kobim kobim closed this as completed in #17 Aug 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants