Skip to content
This repository has been archived by the owner on Aug 1, 2024. It is now read-only.

Manifest File Creation Fix #17

Merged
merged 8 commits into from
Aug 11, 2018
Merged

Manifest File Creation Fix #17

merged 8 commits into from
Aug 11, 2018

Conversation

raymondflores
Copy link
Contributor

@raymondflores raymondflores commented Aug 3, 2018

@coveralls
Copy link

coveralls commented Aug 3, 2018

Pull Request Test Coverage Report for Build 18

  • 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 11: 0.0%
Covered Lines: 65
Relevant Lines: 65

💛 - Coveralls

Copy link
Member

@kobim kobim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you only intend to fix the problem for this package, please revert your last 2 commits (package.json & README.md).
Else (if you intend to publish your own package), please close this PR and make sure to publish your package separately according to the MIT license.

@raymondflores
Copy link
Contributor Author

@kobim I reverted the files the test worked on utils.test.js but was breaking for other reason i could not figure out

@kobim
Copy link
Member

kobim commented Aug 4, 2018

Where did you see a break?

@raymondflores
Copy link
Contributor Author

raymondflores commented Aug 7, 2018

screen shot 2018-08-07 at 2 17 12 pm

I've tried npm install/npm rebuild @kobim

@kobim
Copy link
Member

kobim commented Aug 8, 2018

It's strange your nodejs is trying to run the global jest rather then local. Maybe your NODE_ENV is set to production?
Try this in the project root (verify your npm version is 5 or above):

rm -rf node_modules/
NODE_ENV=development npm install
npm test

and let me know if you succeed.

@raymondflores
Copy link
Contributor Author

screen shot 2018-08-08 at 11 09 17 am
Did not work @kobim

@raymondflores
Copy link
Contributor Author

Can you checkout my fork and see if test run well on your side @kobim

@raymondflores
Copy link
Contributor Author

without this fix this library does not even work

@kobim kobim merged commit aa1166a into MySiteApp:master Aug 11, 2018
@kobim
Copy link
Member

kobim commented Aug 11, 2018

Merged & published to npm.
Thank you for your contribution!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Manifest file creating wrong structure
3 participants