-
Notifications
You must be signed in to change notification settings - Fork 14
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you only intend to fix the problem for this package, please revert your last 2 commits (package.json & README.md).
Else (if you intend to publish your own package), please close this PR and make sure to publish your package separately according to the MIT license.
@kobim I reverted the files the test worked on utils.test.js but was breaking for other reason i could not figure out |
Where did you see a break? |
I've tried npm install/npm rebuild @kobim |
It's strange your nodejs is trying to run the global jest rather then local. Maybe your NODE_ENV is set to production? rm -rf node_modules/
NODE_ENV=development npm install
npm test and let me know if you succeed. |
|
Can you checkout my fork and see if test run well on your side @kobim |
without this fix this library does not even work |
Merged & published to npm. |
new changes for manifest file
fixes #16