Skip to content
This repository has been archived by the owner on Aug 1, 2024. It is now read-only.

Fix memory leak #18

Merged
merged 1 commit into from
Dec 2, 2018
Merged

Fix memory leak #18

merged 1 commit into from
Dec 2, 2018

Conversation

loris
Copy link
Contributor

@loris loris commented Nov 29, 2018

Hi,
Noticed a memory leak when calling the sign method with an intermediate certificate.
Both intermediate and sk variables are leaking.
(I'm only using the sign method, so not sure If another leak is still in the verify method)

@coveralls
Copy link

Pull Request Test Coverage Report for Build 22

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 21: 0.0%
Covered Lines: 65
Relevant Lines: 65

💛 - Coveralls

1 similar comment
@coveralls
Copy link

coveralls commented Nov 29, 2018

Pull Request Test Coverage Report for Build 22

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 21: 0.0%
Covered Lines: 65
Relevant Lines: 65

💛 - Coveralls

@loris
Copy link
Contributor Author

loris commented Nov 30, 2018

FYI, memory usage on our production servers, 4cd9ccbc deploy was first usage of this package, 21912d2e deploy contains this fix.
image

@kobim
Copy link
Member

kobim commented Dec 2, 2018

Hi @loris, thanks for pointing and fixing this!
I'll go ahead and publish it as a new version in a few minutes.

@kobim kobim merged commit 46bd388 into MySiteApp:master Dec 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants