Skip to content
This repository has been archived by the owner on Aug 1, 2024. It is now read-only.

Support node 12 #20

Merged
merged 4 commits into from
Jun 19, 2019
Merged

Support node 12 #20

merged 4 commits into from
Jun 19, 2019

Conversation

kobim
Copy link
Member

@kobim kobim commented Jun 19, 2019

Fixes #19.
Using the new casting to MaybeLocal and dropping support for End-of-Life releases (4, 6, 7 and 11)

@coveralls
Copy link

coveralls commented Jun 19, 2019

Pull Request Test Coverage Report for Build 27

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 24: 0.0%
Covered Lines: 65
Relevant Lines: 65

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 19, 2019

Pull Request Test Coverage Report for Build 29

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 24: 0.0%
Covered Lines: 65
Relevant Lines: 65

💛 - Coveralls

@kobim kobim merged commit 4a1c112 into master Jun 19, 2019
@kobim kobim deleted the fix/node12 branch June 19, 2019 18:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Error on node-gyp rebuild
2 participants