-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/es extra tests #19
base: master
Are you sure you want to change the base?
Feature/es extra tests #19
Conversation
antoniomaciej
commented
Aug 20, 2019
- Fix parsing Spanish zero.
- Delete unnecessary condition for avoiding plural of Spanish word for a third.
- Add missing test cases for full coverage of format_es.py and the es_number_parse method.
- Add ES suffix to ARTICLES collection in common_data_es, according to the convention used across this library. (This line of code is not executed by any unit test, but it also does not seem to be any references to it in the library.)
Delete unnecessary condition for avoiding plural of Spanish word for third. Use proper Spanish tilde symbols in es tests and parse_es.py. Add ES suffix to ARTICLES collection in common_data_es, according to the convention used across this library.
Full branch coverage of es_number_parse in parse_es.py.
Hello, @antoniomaciej, thank you for helping with the Mycroft project! We welcome everyone To protect yourself, the project, and users of Mycroft technologies we require Please visit https://mycroft.ai/cla to initiate this one-time signing. Thank |
Co-authored-by: jarbasal <jarbasai@mailfence.com>
Hi Antonio, Just checking in to see if you're interested in having this code merged still? I haven't looked at the detail since there's no CLA. But if you're happy to sign a CLA we can get it updated, reviewed and merged. If not, that's totally fine too. Thanks |
* bump python-dateutil to latest version * Update requirements.txt