Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/es extra tests #19

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

antoniomaciej
Copy link

  • Fix parsing Spanish zero.
  • Delete unnecessary condition for avoiding plural of Spanish word for a third.
  • Add missing test cases for full coverage of format_es.py and the es_number_parse method.
  • Add ES suffix to ARTICLES collection in common_data_es, according to the convention used across this library. (This line of code is not executed by any unit test, but it also does not seem to be any references to it in the library.)

Delete unnecessary condition for avoiding plural of Spanish word for third.
Use proper Spanish tilde symbols in es tests and parse_es.py.
Add ES suffix to ARTICLES collection in common_data_es, according to the convention used across this library.
Full branch coverage of es_number_parse in parse_es.py.
@JarbasAl JarbasAl added the es relates to spanish language label Sep 11, 2019
@devs-mycroft devs-mycroft added the CLA: Needed Need signed CLA from https://mycroft.ai/cla label Nov 3, 2019
@devs-mycroft
Copy link
Collaborator

Hello, @antoniomaciej, thank you for helping with the Mycroft project! We welcome everyone
into the community and greatly appreciate your help as we work to build an AI
for Everyone.

To protect yourself, the project, and users of Mycroft technologies we require
a Contributor Licensing Agreement (CLA) before accepting any code
contribution. This agreement makes it crystal clear that along with your
code you are offering a license to use it within the confines of this project.
You retain ownership of the code, this is just a license.

Please visit https://mycroft.ai/cla to initiate this one-time signing. Thank
you!

@krisgesling krisgesling added CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) and removed CLA: Needed Need signed CLA from https://mycroft.ai/cla labels Nov 11, 2019
ChanceNCounter pushed a commit to ChanceNCounter/lingua-franca that referenced this pull request Nov 10, 2021
Co-authored-by: jarbasal <jarbasai@mailfence.com>
@krisgesling
Copy link
Contributor

Hi Antonio,

Just checking in to see if you're interested in having this code merged still? I haven't looked at the detail since there's no CLA. But if you're happy to sign a CLA we can get it updated, reviewed and merged.

If not, that's totally fine too.

Thanks

emphasize pushed a commit to emphasize/lingua-franca that referenced this pull request Nov 26, 2022
* bump python-dateutil to latest version

* Update requirements.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) es relates to spanish language
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants