Do not cast extracted datetime to UTC during extract_datetime_fr #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devs-mycroft
added
the
CLA: Yes
NeonJarbas
pushed a commit
to NeonJarbas/ovos-lingua-franca
that referenced
this pull request
Jan 18, 2022
add to_system utility fix extract_datetime_fr timezone bug MycroftAI#218 fix farsi tests (ignoring timezone due to not being rebased before merge) remove unimplemented farsi code (is_fractional and normalize) split english tests into their own files like the other languages
JarbasAl
pushed a commit
to OpenVoiceOS/ovos-lingua-franca
that referenced
this pull request
Jan 18, 2022
* port timezone fixes for time utils MycroftAI#209 add to_system utility fix extract_datetime_fr timezone bug MycroftAI#218 fix farsi tests (ignoring timezone due to not being rebased before merge) remove unimplemented farsi code (is_fractional and normalize) split english tests into their own files like the other languages + remove solved TODO comment authored-by: jarbasai <jarbasai@mailfence.com>
NeonJarbas
pushed a commit
to NeonJarbas/ovos-lingua-franca
that referenced
this pull request
Jan 18, 2022
add to_system utility fix extract_datetime_fr timezone bug MycroftAI#218 fix farsi tests (ignoring timezone due to not being rebased before merge) remove unimplemented farsi code (is_fractional and normalize) split english tests into their own files like the other languages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A datetime was being cast as UTC before being converted to a local tzinfo. This would could an incorrect time extraction.
A backport from Chatterboxes Lingua Nostra:
HelloChatterbox@45a567c
Type of PR
CLA