Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to reflect latest rfc meeting #1

Merged
merged 2 commits into from
Aug 20, 2020
Merged

Updated to reflect latest rfc meeting #1

merged 2 commits into from
Aug 20, 2020

Conversation

doddi
Copy link
Collaborator

@doddi doddi commented Aug 20, 2020

No description provided.

@doddi doddi requested a review from Mykyta August 20, 2020 09:20
Copy link
Owner

@Mykyta Mykyta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good


* **Rationale:**
* This is easy to implement solution to provide such additional value in the HTTP request.
* Building this functionality will allow developers to easily set additional information that can be passed along in a heaer for third-party application use
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo in the "heaer"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


## Implementation

* Define a new `metadata` object that can be added to the package.json file `metadata`.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"metadata" at the end of the sentence is redundant?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mykyta Mykyta self-requested a review August 20, 2020 10:15
@doddi doddi merged commit b8f8d03 into latest Aug 20, 2020
@doddi doddi deleted the md_rfc_changes branch August 20, 2020 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants