feat: support for custom certificate configuration #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Wonderful! It looks generally great for me and I have left some comments.
As this is my first time working with Rust, I apologize if there are any mistakes in my changes.
I wish you gain and learn more than having this feature and implementing this feature, :). learning valuable things like rust and communication are also important as well. I'm and 'll be delighted to review PRs like this.
|
Thank you! |
Myriad-Dreamin
added a commit
that referenced
this pull request
Sep 14, 2024
* feat: support for custom certificate configuration (#592) * feat: add certificate option * refactor: move SystemCompilerFeat into tinymist-world * feat: move HttpRegistry as HttpsRegistry into tinymist-world * feat: add reading pem file * feat: update LspUniverseBuilder::build * feat: fill missing argument of LspUniverseBuilder::build * chore: update lock file for additional dependencies * chore: refine comment for certification * refactor: simplify by new constructor * refactor: sort arguments for threaded_http * refactor: split https.rs from lib.rs in tinymist-world * feat: provide package view and local documentation (#596) * feat: move featured components * feat: provide package view and local documentation * stage * fix: compile error by merged commits * fix: ignore system fonts correctly (#597) * feat: adapt nightly typst chore: use mainline typst fix: `leaf_at` second parameter fix: build `Engine` fix: `interpret_mode_at` converage feat: use my typst fix: use `typst::trace` to trace fix: frameitem fix: new kinds fix: new scope fix: lazyhash fix: result fix: new SyntaxKinds fix: utils, lazyhash chore: remove useless imports fix: sink feat: frameitem fix: export svg with page fix: deref span styl: deps fix: lazyhash deps: use my typstyle fix: enable contenthint with feature fix: leaf_at side fix: compile.output deps fix: warnings deps: use new branch name fix: fix merge error ci: update ci branch test: accept new test snap fix: fix compile deps: update typst fix: fix compilation for latest tinymist fix: fix tests fix: fix tests * chore: clean useless imports --------- Co-authored-by: ricOC3 <100465762+ricOC3@users.noreply.github.com> Co-authored-by: Myriad-Dreamin <35292584+Myriad-Dreamin@users.noreply.github.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request resolves #516.
Thank you for the helpful advice in the issue discussion.
Following suggestions, I have added support for specifying CA certificates of https request through the
--certoption and the environment variableTYPST_CERT, as seen in Typst.I’ve confirmed that the certification error is resolved by either passing the option as follows or setting
TYPST_CERT:{ "tinymist.typstExtraArgs": ["--cert=path/to/certificates"] }As this is my first time working with Rust, I apologize if there are any mistakes in my changes.
I really appreciate your review and guidance.