put rules to right location

external-crates/move/crates/move-compiler/src/sui_mode/linters/custom_rules/meaningless_math_operation.rs → external-crates/move/crates/move-compiler/src/linters/meaningless_math_operation.rs

@@ -9,14 +9,15 @@ use crate::{
     expansion::ast::Value_,
     parser::ast::BinOp_,
     shared::{program_info::TypingProgramInfo, CompilationEnv},
-    sui_mode::linters::{LinterDiagCategory, LINTER_DEFAULT_DIAG_CODE, LINT_WARNING_PREFIX},
     typing::{
         ast::{self as T, Exp, UnannotatedExp_},
         visitor::{TypingVisitorConstructor, TypingVisitorContext},
     },
 };
 use move_ir_types::location::Loc;
 
+use super::{LinterDiagCategory, LINTER_DEFAULT_DIAG_CODE, LINT_WARNING_PREFIX};
+
 const MEANINGLESS_MATH_OP_DIAG: DiagnosticInfo = custom(
     LINT_WARNING_PREFIX,
     Severity::Warning,
@@ -25,13 +26,13 @@ const MEANINGLESS_MATH_OP_DIAG: DiagnosticInfo = custom(
     "Detected a meaningless math operation that has no effect.",
 );
 
-pub struct MeaninglessMathOperationVisitor;
+pub struct MeaninglessMathOperation;
 
 pub struct Context<'a> {
     env: &'a mut CompilationEnv,
 }
 
-impl TypingVisitorConstructor for MeaninglessMathOperationVisitor {
+impl TypingVisitorConstructor for MeaninglessMathOperation {
     type Context<'a> = Context<'a>;
 
     fn context<'a>(

external-crates/move/crates/move-compiler/src/linters/mod.rs

@@ -5,9 +5,9 @@ use move_symbol_pool::Symbol;
 
 use crate::{
     command_line::compiler::Visitor, diagnostics::codes::WarningFilter,
-    linters::shift_overflow::ShiftOperationOverflow, typing::visitor::TypingVisitor,
+    linters::meaningless_math_operation::MeaninglessMathOperation, typing::visitor::TypingVisitor,
 };
-pub mod shift_overflow;
+pub mod meaningless_math_operation;
 #[derive(Debug, Clone, Copy, PartialEq, Eq)]
 pub enum LintLevel {
     // No linters
@@ -20,22 +20,22 @@ pub enum LintLevel {
 
 pub const ALLOW_ATTR_CATEGORY: &str = "lint";
 pub const LINT_WARNING_PREFIX: &str = "Lint ";
-pub const SHILF_OVERFLOW_FILTER_NAME: &str = "shift_overflow";
+pub const MEANINGLESS_MATH_OP_FILTER_NAME: &str = "MeaninglessMathOperation";
 
 pub const LINTER_DEFAULT_DIAG_CODE: u8 = 1;
 
 pub enum LinterDiagCategory {
-    ShiftOperationOverflow,
+    MeaninglessMathOperation,
 }
 
 pub fn known_filters() -> (Option<Symbol>, Vec<WarningFilter>) {
     (
         Some(ALLOW_ATTR_CATEGORY.into()),
         vec![WarningFilter::code(
             Some(LINT_WARNING_PREFIX),
-            LinterDiagCategory::ShiftOperationOverflow as u8,
+            LinterDiagCategory::MeaninglessMathOperation as u8,
             LINTER_DEFAULT_DIAG_CODE,
-            Some(SHILF_OVERFLOW_FILTER_NAME),
+            Some(MEANINGLESS_MATH_OP_FILTER_NAME),
         )],
     )
 }
@@ -44,9 +44,11 @@ pub fn linter_visitors(level: LintLevel) -> Vec<Visitor> {
     match level {
         LintLevel::None => vec![],
         LintLevel::Default | LintLevel::All => {
-            vec![shift_overflow::ShiftOperationOverflow::visitor(
-                ShiftOperationOverflow,
-            )]
+            vec![
+                meaningless_math_operation::MeaninglessMathOperation::visitor(
+                    MeaninglessMathOperation,
+                ),
+            ]
         }
     }
 }