[cli/alias] Add alias to keytool list #15168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
stefan-mysten
force-pushed
the
keytool_list_add_alias_support
branch
from
781f996
to
25b4e0d
Compare
stefan-mysten
force-pushed
the
keytool_list_add_alias_support
branch
from
25b4e0d
to
df8595f
Compare
amnn
approved these changes
Dec 4, 2023
gdanezis
pushed a commit
that referenced
this pull request
Dec 15, 2023
## Description Display alias for each key when calling `sui keytool list`. ## Test Plan Extra tests added for new keystore APIs that were introduced. <img width="1081" alt="image" src="https://github.com/MystenLabs/sui/assets/135084671/60694bc3-40bf-46b0-8756-c42e9bfa52ef"> --- If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process. ### Type of Change (Check all that apply) - [ ] protocol change - [x] user-visible impact - [ ] breaking change for a client SDKs - [ ] breaking change for FNs (FN binary must upgrade) - [ ] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [ ] necessitate either a data wipe or data migration ### Release notes Added functionality to show the aliases of each address when calling the `sui keytool list` command.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Display alias for each key when calling
sui keytool list.Test Plan
Extra tests added for new keystore APIs that were introduced.
If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.
Type of Change (Check all that apply)
Release notes
Added functionality to show the aliases of each address when calling the
sui keytool listCLI command.