Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] Display aliases when calling sui client addresses #15170

Merged

Conversation

stefan-mysten
Copy link
Contributor

@stefan-mysten stefan-mysten commented Dec 3, 2023

Description

Add support for showing aliases when calling sui client addresses.

Test Plan

image

If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.

Type of Change (Check all that apply)

  • protocol change
  • user-visible impact
  • breaking change for a client SDKs
  • breaking change for FNs (FN binary must upgrade)
  • breaking change for validators or node operators (must upgrade binaries)
  • breaking change for on-chain data layout
  • necessitate either a data wipe or data migration

Release notes

Added support for showing aliases when calling the sui client addresses command. If you used to call this command passing the --json flag, the update breaks the format. For each address, it also returns the alias, so each item in the address array is an array itself, containing two elements: alias and address.

Copy link

vercel bot commented Dec 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mysten-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2023 5:43pm
sui-core ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2023 5:43pm
sui-typescript-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2023 5:43pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
explorer ⬜️ Ignored (Inspect) Visit Preview Dec 4, 2023 5:43pm
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Dec 4, 2023 5:43pm
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Dec 4, 2023 5:43pm

Copy link
Member

@amnn amnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

crates/sui/src/client_commands.rs Outdated Show resolved Hide resolved
crates/sui/src/client_commands.rs Outdated Show resolved Hide resolved
@stefan-mysten stefan-mysten enabled auto-merge (squash) December 4, 2023 17:53
@stefan-mysten stefan-mysten merged commit cd566aa into MystenLabs:main Dec 4, 2023
39 checks passed
gdanezis pushed a commit that referenced this pull request Dec 15, 2023
## Description 

Add support for showing aliases when calling `sui client addresses`.

## Test Plan 

<img width="1266" alt="image"
src="https://github.com/MystenLabs/sui/assets/135084671/39357d92-bf87-44de-a3c2-7f9dd4c379eb">


---
If your changes are not user-facing and not a breaking change, you can
skip the following section. Otherwise, please indicate what changed, and
then add to the Release Notes section as highlighted during the release
process.

### Type of Change (Check all that apply)

- [ ] protocol change
- [x] user-visible impact
- [ ] breaking change for a client SDKs
- [ ] breaking change for FNs (FN binary must upgrade)
- [ ] breaking change for validators or node operators (must upgrade
binaries)
- [ ] breaking change for on-chain data layout
- [ ] necessitate either a data wipe or data migration

### Release notes
Added support for showing the aliases when calling the `sui client
addresses` command. If you used to call this command passing the
`--json` flag, the update will break the format. For each address, it
will also give return the alias, so each item in the address array will
be an array itself, containing two elements: alias and address.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants