Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic light client CLI #15187

Merged
merged 21 commits into from
Jan 2, 2024
Merged

Basic light client CLI #15187

merged 21 commits into from
Jan 2, 2024

Conversation

gdanezis
Copy link
Collaborator

@gdanezis gdanezis commented Dec 4, 2023

Description

This PR adds a new command line utility that:

  • Syncs to all end-of-epoch checkpoints found either on a given list or by binary search (less efficient)
  • Check that a TID in a checkpoint sequence number is valid, based on checking committee certificates on the checkpoint, and print the effects digest.
  • Prints all events in a TID or the objects with OID
  • Checks that all types are correct by checking the transactions that created the modules are correct.

Test Plan

How did you test the new or updated feature?


If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.

Type of Change (Check all that apply)

  • protocol change
  • user-visible impact
  • breaking change for a client SDKs
  • breaking change for FNs (FN binary must upgrade)
  • breaking change for validators or node operators (must upgrade binaries)
  • breaking change for on-chain data layout
  • necessitate either a data wipe or data migration

Release notes

Added a basic light client to cryptographically check outcomes of transactions without a Full node. For complete details, see the crate Readme.

Copy link

vercel bot commented Dec 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-core ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 22, 2023 9:14am
sui-typescript-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 22, 2023 9:14am
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
explorer ⬜️ Ignored (Inspect) Visit Preview Dec 22, 2023 9:14am
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Dec 22, 2023 9:14am
mysten-ui ⬜️ Ignored (Inspect) Visit Preview Dec 22, 2023 9:14am
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Dec 22, 2023 9:14am

@gdanezis gdanezis marked this pull request as draft December 4, 2023 16:25
@gdanezis gdanezis changed the title First version of basic light client Basic light client Dec 18, 2023
@gdanezis gdanezis changed the title Basic light client Basic light client CLI Dec 18, 2023
@gdanezis gdanezis marked this pull request as ready for review December 18, 2023 15:43
crates/sui-light-client/src/main.rs Show resolved Hide resolved
crates/sui-light-client/src/main.rs Outdated Show resolved Hide resolved
crates/sui-light-client/src/main.rs Outdated Show resolved Hide resolved
crates/sui-light-client/src/main.rs Show resolved Hide resolved
crates/sui-light-client/src/main.rs Outdated Show resolved Hide resolved
crates/sui-light-client/src/main.rs Outdated Show resolved Hide resolved
crates/sui-light-client/src/main.rs Show resolved Hide resolved
crates/sui-light-client/src/main.rs Outdated Show resolved Hide resolved
crates/sui-light-client/src/main.rs Outdated Show resolved Hide resolved
crates/sui-light-client/src/main.rs Outdated Show resolved Hide resolved
crates/sui-light-client/src/main.rs Show resolved Hide resolved
crates/sui-light-client/src/main.rs Outdated Show resolved Hide resolved
crates/sui-light-client/src/main.rs Outdated Show resolved Hide resolved
crates/sui-light-client/src/main.rs Show resolved Hide resolved
crates/sui-light-client/src/main.rs Outdated Show resolved Hide resolved
)
.is_err());
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some more test for get_verified_object would be nice to see!

Copy link
Contributor

@joyqvq joyqvq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the crypto part lgtm, just a few small questions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants